istio / old_mixer_repo

Deprecated home of Istio's Mixer and its adapters, now in istio/istio's mixer dir
https://github.com/istio/istio/tree/master/mixer
Apache License 2.0
67 stars 93 forks source link

Add auth attributes and change test size for go_default_test #1505

Closed apicl closed 7 years ago

apicl commented 7 years ago

1503

Release note:

NONE

This change is Reviewable

geeknoid commented 7 years ago

@douglas-reid @sebastienvas

What happens when we set a test size to medium? Will the lab still run these tests as part of precommit checks?

apicl commented 7 years ago

It still runs as part of the pre-push. The only different is that the pre-push will wait a little longer.

apicl commented 7 years ago

PTAL

geeknoid commented 7 years ago

/lgtm

geeknoid commented 7 years ago

/lgtm

codecov[bot] commented 7 years ago

Codecov Report

Merging #1505 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1505   +/-   ##
======================================
  Coverage    84.6%   84.6%           
======================================
  Files         122     122           
  Lines       11997   11997           
======================================
  Hits        10150   10150           
  Misses       1646    1646           
  Partials      201     201

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76287ad...5c4239e. Read the comment docs.

istio-merge-robot commented 7 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/istio/mixer/blob/master/OWNERS)~~ [geeknoid] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
istio-merge-robot commented 7 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

douglas-reid commented 7 years ago

@geeknoid small -> medium shouldn't have any observable impact. moving to large or bigger will, based on our configuration, which includes:

test --test_size_filters=-large,-enormous
istio-merge-robot commented 7 years ago

Automatic merge from submit-queue.