Closed apicl closed 7 years ago
@douglas-reid @sebastienvas
What happens when we set a test size to medium? Will the lab still run these tests as part of precommit checks?
It still runs as part of the pre-push. The only different is that the pre-push will wait a little longer.
PTAL
/lgtm
/lgtm
Merging #1505 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1505 +/- ##
======================================
Coverage 84.6% 84.6%
======================================
Files 122 122
Lines 11997 11997
======================================
Hits 10150 10150
Misses 1646 1646
Partials 201 201
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 76287ad...5c4239e. Read the comment docs.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
/test all [submit-queue is verifying that this PR is safe to merge]
@geeknoid small
-> medium
shouldn't have any observable impact. moving to large
or bigger will, based on our configuration, which includes:
test --test_size_filters=-large,-enormous
Automatic merge from submit-queue.
1503
Release note:
This change is