Closed istio-testing closed 7 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: We suggest the following additional approver: geeknoid
Assign the PR to them by writing /assign @geeknoid
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/test all [submit-queue is verifying that this PR is safe to merge]
Merging #1512 into master will increase coverage by
<.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1512 +/- ##
==========================================
+ Coverage 84.57% 84.57% +<.01%
==========================================
Files 122 122
Lines 11997 11997
==========================================
+ Hits 10146 10147 +1
+ Misses 1650 1649 -1
Partials 201 201
Impacted Files | Coverage Δ | |
---|---|---|
adapter/stackdriver/metric/bufferedClient.go | 92.5% <0%> (+2.5%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 08f4f36...18ecac2. Read the comment docs.
Automatic merge from submit-queue.
This PR will be merged automatically once checks are successful.
This change is