search

istio / old_mixer_repo

Deprecated home of Istio's Mixer and its adapters, now in istio/istio's mixer dir
https://github.com/istio/istio/tree/master/mixer
Apache License 2.0
67 stars 93 forks source link

Adapters (check, quota, APAs) should communicate back to mixer on what input fields they used. #1522

Open guptasu opened 6 years ago

guptasu commented 6 years ago

For APAs and for other adapters too, we need a mechanism to figure out what input fields did the adapter used within a scope of a given request. This information along with operator configuration will help Mixer identify the smallest set of attributes used to serve a request, which indirectly will help reduce the attribute based cache key size and might result into higher cache hit rate.

For APAs, when we call the APA we need to tell it which of its outputs are actually going to be consumed and hence need to be populated. This will allow the adapter to avoid generating stuff that no one looks at, and will help the adapter reduce the set of input attributes it touches.

guptasu commented 6 years ago

@geeknoid do we already have an issue for this, I couldn't find it and therefore created it and referenced it from my APA to template model migration work (#1477)

geeknoid commented 6 years ago

I don't think we'll get much leverage for this idea for check & quota adapters. I'm much more interested in APAs at the moment.