search

istio / old_mixer_repo

Deprecated home of Istio's Mixer and its adapters, now in istio/istio's mixer dir
https://github.com/istio/istio/tree/master/mixer
Apache License 2.0
67 stars 93 forks source link

Make Result.Interface() return an empty string, as is. #1523

Closed ozevren closed 7 years ago

ozevren commented 7 years ago

Release note:

NONE

This change is Reviewable

ozevren commented 7 years ago

Fixes https://github.com/istio/mixer/issues/934

ozevren commented 7 years ago

/test mixer-presubmit

Test passes when run locally.

codecov[bot] commented 7 years ago

Codecov Report

Merging #1523 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
+ Coverage   84.55%   84.57%   +0.01%     
==========================================
  Files         122      122              
  Lines       11999    11994       -5     
==========================================
- Hits        10146    10144       -2     
+ Misses       1651     1648       -3     
  Partials      202      202
Impacted Files Coverage Δ
pkg/il/interpreter/result.go 100% <100%> (ø) :arrow_up:
adapter/prometheus/server.go 94.91% <0%> (+5.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5253b6b...1cd1de7. Read the comment docs.

ozevren commented 7 years ago

friendly ping

douglas-reid commented 7 years ago

/hold

douglas-reid commented 7 years ago

with the repo migration in-flight, we shouldn't merge any PRs at the moment.

ozevren commented 7 years ago

What is the ETA for repo migration completion?

douglas-reid commented 7 years ago

@ozevren i've been led to believe that it will be Wed. Nov. 1. Any PRs submitted now would be lost in the shuffle. Unfortunately, this means you will have to move these changes over and resubmit (with hopefully a successful transfer of test infra, etc., already done and working). :(.

geeknoid commented 7 years ago

This repo is no longer accepting PRs. Please resubmit this change to the istio/istio repo.

Thanks.