istio / old_mixer_repo

Deprecated home of Istio's Mixer and its adapters, now in istio/istio's mixer dir
https://github.com/istio/istio/tree/master/mixer
Apache License 2.0
67 stars 93 forks source link

Review metric schema in context of other OSS projects #37

Closed louiscryan closed 7 years ago

louiscryan commented 7 years ago

Worthwhile to look at concepts in other systems to see how we map. Please add more here ....

Prometheus https://github.com/prometheus/client_model/blob/086fe7ca28bde6cec2acd5223423c1475a362858/metrics.proto#L76-%20%20L81

New Relic attributes: https://docs.newrelic.com/docs/agents/manage-apm-agents/agent-data/collect-custom-attributes metrics: https://docs.newrelic.com/docs/agents/manage-apm-agents/agent-data/custom-metrics well-known attributes: https://docs.newrelic.com/docs/insights/new-relic-insights/decorating-events/insights-attributes

AppDynamics: custom metrics: https://docs.appdynamics.com/display/PRO42/Analytics+Events+API well known attributes: https://docs.appdynamics.com/display/PRO42/Transaction+Analytics+Data

DynaTrace: well-known attributes: https://community.dynatrace.com/community/display/APMSAASDOC/Data+Models+for+REST+API+Payloads

douglas-reid commented 7 years ago

Statsd: https://github.com/etsy/statsd/blob/master/docs/metric_types.md

douglas-reid commented 7 years ago

Also worth considering:

wora commented 7 years ago

Stackdriver Monitoring will publish its API metrics soon. Please consider it as well.

curlup commented 7 years ago

Please consider also http://metrics20.org/

and https://github.com/vimeo/carbon-tagger

geeknoid commented 7 years ago

Zack, do we need to do anything specific here?

ZackButcher commented 7 years ago

Given our decisions around descriptors where we punt to adapter config to handle backend representation (so our representation of a metric in Istio is just a value and dimensions, nothing else) I think we're fine on this front.