istio / old_mixer_repo

Deprecated home of Istio's Mixer and its adapters, now in istio/istio's mixer dir
https://github.com/istio/istio/tree/master/mixer
Apache License 2.0
67 stars 93 forks source link

Create a custom linter for //adapter code. #458

Open ZackButcher opened 7 years ago

ZackButcher commented 7 years ago

We've created a framework with a lot of assumptions for adapter authors; things that are common patterns in go we don't actually want our adapter authors doing. We should look in to writing a custom linter that calls out anti-patterns in adapter code. Specifically, we should check for things like:

All of these patterns must also be documented in our adapter authors guide.

douglas-reid commented 7 years ago

Jury is still out on adapter.ConfigErrors, but in general I think this would be useful.