search

istio / old_mixer_repo

Deprecated home of Istio's Mixer and its adapters, now in istio/istio's mixer dir
https://github.com/istio/istio/tree/master/mixer
Apache License 2.0
67 stars 93 forks source link

Liveliness and Readiness probes for Mixer #741

Open mandarjog opened 7 years ago

mandarjog commented 7 years ago

Mixer starts and asynchronously loads configuration.

There is a time during which Mixer may return configuration is not available error. Mixer should never receive traffic from proxies while it is in this state.

kyessenov commented 7 years ago

This is somewhat different I think. Liveness means mixer is unhealthy and should be removed from LB pool (cannot be done in alpha since it's a singleton). Readiness means mixer is overwhelmed and should be removed from LB pool - also not applicable. Can you just declare a dependency on the configmap resource you need instead?

mandarjog commented 7 years ago

This is not for alpha.

Declaring dependency on config map is not enough, also we don't use them :-) But generally the dependency is on the config store which can declare. It is however not a sufficient condition for Mixer to start serving requests.

Mixer should fail readiness checks when it is clearly not ready. That is the intended use of readiness.

  1. It can happen at startup when config has not been loaded yet
  2. If Mixer loses connection to back end services or config store.