Closed mcwienczek closed 6 years ago
Hi @mcwienczek. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: We suggest the following additional approver: kyessenov
Assign the PR to them by writing /assign @kyessenov
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Merging #1624 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1624 +/- ##
=======================================
Coverage 82.78% 82.78%
=======================================
Files 52 52
Lines 6423 6423
=======================================
Hits 5317 5317
Misses 901 901
Partials 205 205
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6f20fc3...bb7cc8d. Read the comment docs.
@codecov[bot]: you can't request testing unless you are a istio member.
/ok-to-test
/test pilot-e2e-smoketest
Changed makefile to use bazel darwin build flag
fixes #1581
Release note: