istio / old_pilot_repo

Deprecated home of Istio's Pilot, now in istio/istio's pilot dir
Apache License 2.0
137 stars 91 forks source link

istioctl kube-inject doesn't work when my pod has 2 containers #1640

Closed linsun closed 6 years ago

linsun commented 6 years ago

I'm having a 2 container pod and using istioctl kube-inject didn't see istio-proxy side car injected.

A simple test yaml from a tutorial (https://www.mirantis.com/blog/multi-container-pods-and-container-communication-in-kubernetes/)


kind: Pod
metadata:
  name: mc3
  labels:
    app: mc3
spec:
  containers:
  - name: webapp
    image: training/webapp
  - name: nginx
    image: nginx:alpine
    ports:
    - containerPort: 80
    volumeMounts:
    - name: nginx-proxy-config
      mountPath: /etc/nginx/nginx.conf
      subPath: nginx.conf
  volumes:
  - name: nginx-proxy-config
    configMap:
      name: mc3-nginx-conf```
ayj commented 6 years ago

I don't think this has to do with number of containers per pod. kind: Pod is missing from the list of supported resource kinds here and IntoResourceFile only injects into recoginized resource kinds.

kyessenov commented 6 years ago

Issue moved to istio/istio #1363 via ZenHub