search

istio / old_pilot_repo

Deprecated home of Istio's Pilot, now in istio/istio's pilot dir
Apache License 2.0
137 stars 91 forks source link

WIP - Add quota and apispec to mixerclient filter configuration #1661

Closed ayj closed 6 years ago

ayj commented 6 years ago

What this PR does / why we need it:

Add scaffolding for including HTTPAPISpec and QuotaSpec in mixerclient filter configuration.

TODO

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

istio-testing commented 6 years ago

@ayj: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed. Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ayj commented 6 years ago

Posting this for early review before I finished fleshing out the implementation.

/cc @rshriram @kyessenov

ayj commented 6 years ago

This PR includes the full diff from https://github.com/istio/pilot/pull/1644. See commit https://github.com/istio/pilot/pull/1661/commits/e8154de2b930d4b6b93f63e5dc1b9eff98fb7de4 for the specific changes to add quota and apispec to mixerclient filter config.

istio-testing commented 6 years ago

@ayj: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/pilot-presubmit.sh a97994d900d653e2c64a683f2c9723187166120b link /test pilot-presubmit
Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).
rshriram commented 6 years ago

Closing.. code moved to istio/istio