Closed jmuk closed 6 years ago
/lgtm
@ldemailly: changing LGTM is restricted to assignees, and assigning you to the PR failed.
/lgtm
/lgtm
@andraxylia: changing LGTM is restricted to assignees, and assigning you to the PR failed.
/assign @andraxylia
/ok-to-test
/retest
Merging #1666 into release-0.2 will increase coverage by
0.04%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## release-0.2 #1666 +/- ##
===============================================
+ Coverage 82.69% 82.74% +0.04%
===============================================
Files 52 52
Lines 6426 6426
===============================================
+ Hits 5314 5317 +3
+ Misses 909 907 -2
+ Partials 203 202 -1
Impacted Files | Coverage Δ | |
---|---|---|
platform/consul/monitor.go | 83.33% <0%> (+3.57%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 25d7796...1d20f1c. Read the comment docs.
/retest
/retest
https://github.com/istio/issues/issues/110 reminds me that istioctl can set empty namespace for mixer configs, which will be delivered directly and therefore it can cause same error of "empty namespace".
When the obtained namespace happens to be empty, I think it should return the default value.
(cherry picked from commit c67bb1450974fa8916f74862dee5c3f8f37f0edf)
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: