Closed ayj closed 6 years ago
@ayj: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.
@ayj: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.
/lgtm
@rkpagadala: changing LGTM is restricted to assignees, and assigning you to the PR failed.
/approve
This repo is no longer accepting PRs. Please resubmit this change to the istio/istio repo.
Thanks.
Let's not close releaze-0.2 bug fixes
Conflict?
looks conflicting my recent fix (https://github.com/istio/old_pilot_repo/pull/1638), be careful to resolve without breaking my one.
@ayj ping, is this needed for 0.2 ?
Merging #1667 into release-0.2 will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## release-0.2 #1667 +/- ##
============================================
Coverage 82.69% 82.69%
============================================
Files 52 52
Lines 6426 6426
============================================
Hits 5314 5314
Misses 909 909
Partials 203 203
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 998e0e0...34b77a1. Read the comment docs.
so we just missed 0.2.11 / what's the impact ?
Users need to specify a valid kubeconfig with --kubeconfig
or have a valid default config discoverable through KUBECONFIG
k not too bad, connectivity to the cluster is needed for kube-inject anyway for instance
The following panic occurs if kubectl's current-context does not point to a valid configuration context.
fixes https://github.com/istio/issues/issues/105