istio / old_pilot_repo

Deprecated home of Istio's Pilot, now in istio/istio's pilot dir
Apache License 2.0
137 stars 91 forks source link

Support release-0.2 branch in old repo #1672

Closed yutongz closed 6 years ago

yutongz commented 6 years ago

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

none
codecov[bot] commented 6 years ago

Codecov Report

Merging #1672 into release-0.2 will increase coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-0.2    #1672      +/-   ##
===============================================
+ Coverage        82.69%   82.74%   +0.04%     
===============================================
  Files               52       52              
  Lines             6426     6426              
===============================================
+ Hits              5314     5317       +3     
+ Misses             909      907       -2     
+ Partials           203      202       -1
Impacted Files Coverage Δ
platform/consul/monitor.go 83.33% <0%> (+3.57%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 918a843...e1bbffa. Read the comment docs.

chxchx commented 6 years ago

/lgtm

wattli commented 6 years ago

@andraxylia , please take a look, we need this for the release