Closed mdhume closed 6 years ago
@mdhume: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.
Hi @mdhume. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.
@linsun @rkpagadala Any updates on when the next 0.2 release will be? Also when will 0.3 be out?
@mdhume: you can't request testing unless you are a istio member.
@mdhume We are currently not planning on a .2 release. We expect to release a .3 in a couple of weeks.
Merging #1683 into release-0.2 will increase coverage by
<.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## release-0.2 #1683 +/- ##
===============================================
+ Coverage 82.69% 82.69% +<.01%
===============================================
Files 52 52
Lines 6426 6427 +1
===============================================
+ Hits 5314 5315 +1
Misses 909 909
Partials 203 203
Impacted Files | Coverage Δ | |
---|---|---|
proxy/envoy/resources.go | 85.08% <ø> (ø) |
:arrow_up: |
proxy/envoy/ingress.go | 77.27% <100%> (+0.17%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 998e0e0...00550ca. Read the comment docs.
@codecov[bot]: you can't request testing unless you are a istio member.
please make PRs in istio/istio/pilot
I did not notice at first this was for the release branch, my bad, but is it done on master already - which PR ?
also I don’t think we will be making a 0.2 patch after 0.2.12 - this should go on master/0.3.0
@ldemailly Yes it was merged here - https://github.com/istio/istio/pull/1294 . Is there any ETA on 0.3? We really need this fix to get grpc-java working for us.
we're supposed to be doing daily and weekly builds... the mono repo and other changes have delayed this so far but it should be imminent cc @guptasu , @mattdelco, @jasminejaksic
The goal/expectation is to have a release this week. The remaining tasks are mostly about navigating certain infrastructure and procedural issues/barriers (some of which are harder to workaround during a holiday week) so I don't have a more precise ETA besides Mon-Wed.
New ETA is Monday. The build process was running fine but we had difficulties locating a version of the code base that would pass all the required test suites. A viable candidate was identified towards the end of the day but the actual release won't happen until after the coming holiday weekend.
@mattdelco Sounds good, thanks for the update.
What this PR does / why we need it: @rkpagadala @linsun @rshriram This PR adds the param "alpn_protocols" for listener ssl context as documented here - https://www.envoyproxy.io/envoy/configuration/listeners/ssl.html#config-listener-ssl-context Currently grpc-java clients require that the proxy return a selected alpn_protocol else it errors out. The discussion on this issue is detailed here - https://groups.google.com/forum/#!topic/istio-users/MYRflKPQRkA I am intentionally leaving the cluster ssl context untouched here.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: These changes have been merged into master branch in the istio/istio repo - https://github.com/istio/istio/pull/1294 Without this PR we are currently blocked on using any grpc-java service over TLS with Istio, hence we would be grateful if this gets merged into the next 0.2 release.
Release note: