search

istio / old_pilot_repo

Deprecated home of Istio's Pilot, now in istio/istio's pilot dir
Apache License 2.0
137 stars 91 forks source link

ability to change envoy configuration without istio code change/release #883

Closed ldemailly closed 7 years ago

ldemailly commented 7 years ago

there should be an optional "merge" or "patch" or externalized template so people can tweak the resulting envoy configs

ps: it does mean they can also break istio but that's not a reason to have it completely locked down and hardcoded like now

rshriram commented 7 years ago

I don't think this is a good idea. We have covered 90% of Envoy config. Allowing people to break istio while trying to provide seamless experience is contradictory.

Very few people have asked for this.

ldemailly commented 7 years ago

it should be possible to patch or change config without making a new release - if only for emergency fixes

kyessenov commented 7 years ago

Plausible but difficult to reconcile custom templates with machine-generated config. Feels like a hacky workaround overall. Assigning it to you to think of ways to reconcile the two.

ldemailly commented 7 years ago

putting it for 0.3 as I'm pretty sure we'll learn in 0.2 and rawvm that we need this

kyessenov commented 7 years ago

Issue moved to istio/istio #1396 via ZenHub