istio / test-infra

Apache License 2.0
72 stars 171 forks source link

Idea: Extending Authentikos to other credential types #2659

Open wlynch opened 4 years ago

wlynch commented 4 years ago

Hi!

Over at the Tekton project, we've been thinking about how to handle GitHub App credentials. We ended up leaning towards a refresher design just like Authentikos, since GitHub App short-lived installation tokens act very similar to Google OAuth access tokens. It would be great if we could extend Authentikos to support this. :D

I wanted to reach out to find out if this would this be of interest to the Authentikos project (i.e. should we upstream changes here or fork our own version)?

Thanks!

clarketm commented 4 years ago

Hi @wlynch,

I read the proposal. It would be ideal to coalesce the refresher design proposal (and support for new credential types) with upstream Authentikos (given the similarities). Currently, Authentikos is quite configurable but we can extend it as needed to support Tekton's needs. I would be more than happy to assist in any way I can! Alternatively, if you prefer to fork that is fine as well.

wlynch commented 4 years ago

Great! We have interns ramping up on the team right now, and I think this might make a good project. We'll circle back in a few weeks with a more concrete design w.r.t. integrating with Authentikos for review!