search

istio / test-infra

Apache License 2.0
73 stars 174 forks source link

Fix codecov.io's "No coverage uploaded for pull request base" with Jenkins #72

Closed ayj closed 7 years ago

ayj commented 7 years ago

Codecov.io is mostly working with Jenkins on istio.io/manager. We still need to generate coverage reports upon successful merge into the master branch so codecov.io can properly generate coverage % diff against master (see warning message below). I think we just need to re-run coverage report on post-submit/commit trigger.

No coverage uploaded for pull request base (master@f3fdddb). Click here to learn what that means.

sebastienvas commented 7 years ago

I am wondering if it ll make more sense to have a git repo with all the scripts that we share instead of having them in istio testing. then we can use a git submodule for those on each repo. That way we can share best practices more easily.

ayj commented 7 years ago

Sounds reasonable assuming the individual repos share common structure, development, practices, etc. But not sure how that would affect this particular issue? I thought the "no coverage" error was because we aren't generating coverage report on merged commits to master via post-submit hook?

sebastienvas commented 7 years ago

For this issue I ll just create a shared method to publish Code Coverage and will leave the /bin/codecov script.

sebastienvas commented 7 years ago

this was resolved with #85.