istio / ztunnel

The `ztunnel` component of ambient mesh
Apache License 2.0
287 stars 96 forks source link

Support full Service API #204

Open howardjohn opened 1 year ago

howardjohn commented 1 year ago

If we are going to be a drop in we need to support the full featuteset of Service. This includes the locality aware stuff, affinity, etc.

Depends on https://github.com/istio/ztunnel/issues/152. This should have a proper design before any implementation

hzxuzhonghu commented 1 year ago

cc

howardjohn commented 5 months ago

internalTrafficPolicy: done https://github.com/istio/ztunnel/pull/868 clusterIP, ports: done sessionAffinity: https://github.com/istio/ztunnel/issues/450, TODO externalName: nothing needed externalIPs: I think nothing needed?

So we are in pretty good shape. sessionAffinity is rarely used so I don't mind putting that off for a while

daixiang0 commented 5 months ago

I want to implement serviceAffinity if possible.

My design is like what the k8s does as https://kubernetes.io/docs/reference/networking/virtual-ips/#session-affinity.

howardjohn commented 5 months ago

Do you have a strong use case for this? I worry the complexity of this outweighs the benefits, at least for the next 6 months or so while we are working on stabilizing core

howardjohn commented 2 weeks ago

AFAIK the only remaining is https://github.com/istio/ztunnel/issues/450