istio / ztunnel

The `ztunnel` component of ambient mesh
Apache License 2.0
301 stars 101 forks source link

Track performance of ztunnel in CI #214

Open howardjohn opened 1 year ago

howardjohn commented 1 year ago

We have benchmarks but no tracking.

Requirements:

PiotrSikora commented 1 year ago

Doesn't this pretty much require dedicated metal for CI?

howardjohn commented 1 year ago

If we run HEAD and HEAD^ on the same machine it might be sufficient, assuming there is minimal noise within a single machine. We can get a dedicated node in prow so there is at least only our single job running on it. Although that makes the graph not really work.

PiotrSikora commented 1 year ago

I'm getting +/- 5% between subsequent runs on the same VM, and that granularity would hide small regressions.

howardjohn commented 1 year ago

Bummer... we could try increasing sample sizes/iterations in criterion but if there is enough noise it may still be tricky.

I think its important to have some way to make sure performance is not regressing. That may not be easy though, and may end up looking different than "run the job in prow" I suppose

jaellio commented 1 year ago

@Stevenjin8

Stevenjin8 commented 1 year ago

Bullets 1 and 4 (ish) are done through #559 and #551, but tests are very noisy.