istopwg / ippeveselfcert

IPP Everywhere Printer Self-Certification Tools
https://www.pwg.org/ipp/everywhere.html
Apache License 2.0
21 stars 6 forks source link

Hard-coded filename(s) prevent "document-tests.sh" from running #1

Closed KurtPfeifle closed 8 years ago

KurtPfeifle commented 8 years ago

In lieu of a suitable IPP printer in my current environment I resorted to test against a locally installed CUPS-1.7.5 queue (knowing it is not supposed to pass most of the tests, but wanting to see in general how this testing would work). This is when I noticed the problem with the hard-coded versions, plus the following:

"document-tests.test":
    D-1. PWG Raster Format Tests (mandatory)                             [PASS]
ipptool: Filename "pwg-raster-samples-${RASTER_RESOLUTION}-20111130/black-1/color.jpg-4x6-black-1-600dpi.pwg" on line 68 cannot be read.
ipptool: Filename mapped to "pwg-raster-samples-1200dpi-20111130/black-1/color.jpg-4x6-black-1-600dpi.pwg".

That "line 68" is from "document-tests.test". It reads:

   FILE pwg-raster-samples-${RASTER_RESOLUTION}-20111130/black-1/color.jpg-4x6-black-1-600dpi.pwg

I'm not sure why the var ${RASTERRESOLUTION} did not resolve in the output line? And why it seems to be "mapped to 1200dpi"? And why is the "600dpi.pwg" file suffix hard-coded throughout the "document-tests.test"_ file?


(Note, I've not run this on one of the required/recommended OS platforms, but on Debian Jessie.)

michaelrsweet commented 8 years ago

OK, just pushed a fix for this issue. Tested end-to-end with different ippserver settings to make sure things were working reliably...

Please stick with the sample files from 20150616 since the older files contains errors.