istopwg / ippeveselfcert

IPP Everywhere Printer Self-Certification Tools
https://www.pwg.org/ipp/everywhere.html
Apache License 2.0
21 stars 6 forks source link

'ipp-tests.sh' should be modified to accommodate service instance names with awkward instance name syntax #3

Closed wifiprintguy closed 8 years ago

wifiprintguy commented 8 years ago

The invocation of 'ippfind' should use the '-n' or '--name' option to make sure it can handle instance names that start with characters such as '_' that are used in the real world but are not supported by the currently used version of 'ippfind'

So, change this:

${IPPFIND} "$1._ipp._tcp.local." -x "${IPPTOOL}" -P "$1 IPP Results.plist" -I '{}' ipp-tests.test \;

to this:

${IPPFIND} --name "${1}" "_ipp._tcp.local." -x "${IPPTOOL}" -P "$1 IPP Results $(date +'%Y%m%d%H%M').plist" -I '{}' ipp-tests.test \;

(This also includes an additional date code element in the plist file name created to better support multiple runs.)