istopwg / ippeveselfcert

IPP Everywhere Printer Self-Certification Tools
https://www.pwg.org/ipp/everywhere.html
Apache License 2.0
21 stars 6 forks source link

Test for finishings support should define HAVE_FINISHINGS if "finishings-supported" has value other than 3 (none) #47

Closed wifiprintguy closed 4 years ago

wifiprintguy commented 4 years ago

This line:

https://github.com/istopwg/ippeveselfcert/blob/b382cc129d055a9ac3aa949ebaf9a85563c732ea/tests/ipp-tests.test#L369

Should say instead:

EXPECT finishings-supported OF-TYPE enum IN-GROUP printer-attributes-tag WITH-VALUE >3 DEFINE-MATCH HAVE_FINISHINGS

This way it will only define HAVE_FINISHINGS if "finishings-supported" contains a value other than 3 (none).

michaelrsweet commented 4 years ago

[master e73039f] Only define HAVE_FINISHINGS if finishings-supported has a value other than '3' (none). (Issue #47)