search

istopwg / ippeveselfcert

IPP Everywhere Printer Self-Certification Tools
https://www.pwg.org/ipp/everywhere.html
Apache License 2.0
21 stars 6 forks source link

DNS-SD tests not working properly on Windows #83

Closed michaelrsweet closed 2 years ago

michaelrsweet commented 2 years ago

After testing the current self-cert tools on Windows 10 and 11, I find that the DNS-SD tools are not working properly. It appears that the environment variables that ippfind passes to ipptool are not getting through somehow, preventing the value tests from working.

michaelrsweet commented 2 years ago

OK, so it looks like the Windows port of ippfind does not quote all values going to _spawnvpe, which apparently is required since there is no way to pass separate argument strings like in Unix!

_spawnvpe documentation CreateProcessA documentation

I still need to do some more digging...

michaelrsweet commented 2 years ago

Windows command-line parsing documentation

Potential fix (pending testing):

[master b83d6eb] Fix ippfind and DNS-SD test issues (Issue #83)

michaelrsweet commented 2 years ago

OK, so in addition Windows defaults to a 4k maximum stack size ?!? ipptool was generating a stack overflow thanks to the 1MB value buffer change to report large media-col-database values...

michaelrsweet commented 2 years ago

OK, so with all of that and a bunch of other quoting fixes throughout the batch files, everything seems to be working.