search

istopwg / ippsample

IPP sample implementations.
http://istopwg.github.io/ippsample
Apache License 2.0
221 stars 80 forks source link

Test docker image #243

Closed thenewguy closed 11 months ago

thenewguy commented 2 years ago

We create a docker image. We should run some tests against it to make sure it works as expected before uploading it

thenewguy commented 2 years ago

@michaelrsweet I haven't read how the test suite works. Any suggestions for commands we can run against the image to verify all is in working order? Is it possible to reuse any of the test suite against the built image

michaelrsweet commented 2 years ago

@thenewguy Right now there isn't a test suite - it's on the TODO list... :/

thenewguy commented 2 years ago

242 adds some simple sanity tests that the expected commands are available and are able to be executed. A few gotchas to fix per #244 but this minimally confirms the docker image is usable

RomanWoerner commented 2 years ago

Hello There! The Docker-image u create, is it ready to use? I used the Compose-File in the Project-Direcory, but it says "Error: Service 'ippserver' failed to build: Build failed

michaelrsweet commented 2 years ago

@RomanWoerner I'm not sure why the build is failing now, investigating...

michaelrsweet commented 2 years ago

@RomanWoerner OK, I think I've fixed the build via docker build -t ippsample . - let me know how it works for you.

michaelrsweet commented 2 years ago

@RomanWoerner I've also updated the docker compose support and fixed a bug in the conf file loading code - seems to all be working now.

RomanWoerner commented 2 years ago

Hey ! Thank u for ur quick answer and help! I now have a Error, that says executor failed running [/bin/sh -c ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var; test -f server/ippserver && make clean; make; make install]: exit code: 2 . Maybe i do something wrong. What i did -> Downloaded ur updated folder-> Started Docker with elevated Privileges (Administrator Win10) -> Changed into the Directory and used docker build -t ippsample . . I Already searched in Google for a solution, before i comment here again. Some Arguments for elevated permissions and stuff didnt change the error-code. I run Docker with the Default Settings and on WSL2.

michaelrsweet commented 11 months ago

[master 655160d] Some Docker cleanup/clarifications.