Add .ahab support for Android

istornz / flutter_gaimon

A Flutter plugin to fully support Haptic feedback with custom pattern 📳

MIT License

27 stars 6 forks source link

Add .ahab support for Android #10

Closed Bassiuz closed 4 months ago

Bassiuz commented 5 months ago

This is the start of supporting .ahab files for Android.

closes https://github.com/istornz/flutter_gaimon/issues/11

[X] Parse .ahab json contents
[X] Convert events in pattern to waveform
[X] Send waveform to android native plugin to simulate waveform
[x] Add support for parameters (https://developer.apple.com/documentation/corehaptics/representing-haptic-patterns-in-ahap-files)
[x] Add support for Parameter curves
[ ] Add support for AttackTime
[ ] Add support for DecayTime
[ ] Add support for Sustained Events

SuhwanCha commented 4 months ago

@istornz Can it be merged and published? I'm looking forward it

Bassiuz commented 4 months ago

@SuhwanCha ; Cool that you are looking forward to it! I intend to finish up the last of these points next friday. Whenever that is finished I will convert it from a draft to an actual pr so we can merge it.

istornz commented 4 months ago

@SuhwanCha ; Cool that you are looking forward to it! I intend to finish up the last of these points next friday. Whenever that is finished I will convert it from a draft to an actual pr so we can merge it.

Thanks @Bassiuz

Bassiuz commented 4 months ago

@istornz I added support for parameters and parameter curves. These curves are still linear instead of curved with attack/sustain and release, but for the first release I think that is acceptable.

The curves feel somewhat acceptable, however the difference in sharpness isn't feelable, as I didn't apply it to the amplitude of the waveform. So only if you have a .ahap that makes use of a lot of Intensity Curves or other intensity controls you will feel similair results.

Do you have a good idea to combine the sharpness into the waveform? Should I treat it as a certain multiplier? (improve the amplitude for very sharp haptics, lower it when the sharpness is very low?)

istornz commented 4 months ago

Hi @Bassiuz thanks for your awesome PR! I think we can merge it right now & improve it in the future 👍 (I'm in vacation now I will check how to implement extra feature later).

What do you think?

Thanks for your work!

Bassiuz commented 4 months ago

@istornz Yeah lets just merge it for now and brainstorm on how to improve and expand later.

Are you by any chance able to create a release?

Enjoy your vacation! 🏖️

istornz commented 4 months ago

@Bassiuz I will do a release next week I think 👍

Thanks 🙏

istornz commented 4 months ago

Release v1.3.0 is now live on pub.dev 👍