search

istornz / flutter_live_activities

A Flutter plugin to use iOS 16.1+ Live Activities ⛹ī¸ & iPhone Dynamic Island 🏝ī¸ features
https://dimitridessus.fr/
MIT License
175 stars 54 forks source link

#53 - Fix stall state for unknown activityId #55

Closed Clon1998 closed 11 months ago

Clon1998 commented 11 months ago

Fixes #53. On the Flutter side, ensures completion of the future even if the provided activityId is not found in the active live activity list on the iOS side.

Discussion: It is unclear whether returning an error or an unknown state is more beneficial when the activity ID is unknown.

istornz commented 11 months ago

Thanks for your PR @Clon1998, we can return a null value if the activity id is not found, what do you think about it?

Clon1998 commented 11 months ago

Thanks for your PR @Clon1998, we can return a null value if the activity id is not found, what do you think about it?

Ohh right! I somehow did not consider a nil/null value but that's also a great idea!

istornz commented 11 months ago

Release v1.9.0 available 👍 Thanks for your PRs :)