search

istornz / iPokeGo

A native iOS client to map the Pokemon around you!
https://github.com/RocketMap/RocketMap
MIT License
642 stars 168 forks source link

[Enhancement] Fetch scan location from server #231

Closed dmunozfer closed 8 years ago

dmunozfer commented 8 years ago

PokemonGo-Map send scan location coordinates in http://hostaname-pokemongomap/loc

{ "lat": 40.41564693411584, "lng": -3.683897057250988 }

Insted of load scan location from user preferences, would not it be better to get it from the server? I do not know pogom, also have this option?

dmunozfer commented 8 years ago

Implemented in PR #251

istornz commented 8 years ago

Nice, thx. I added this functionality for pogom.

danielmj commented 8 years ago

This functionality actually is not working for me. I think because there is a mismatch between the NSUserDefaults value: server_type and SERVER_API_DATA_POKEMONGOMAP in the fetchScanLocationData method.

Here are the values that mine is returning: [NSUserDefaults objectForKey:@"server_type"]: %%server_addr%%/raw_data?pokemon=%%pokemon_display%%&pokestops=%%pokestops_display%%&gyms=%%gyms_display%%

SERVER_API_DATA_POKEMONGOMAP: %%server_addr%%/raw_data?pokemon=%%pokemon_display%%&pokestops=%%pokestops_display%%&gyms=%%gyms_display%%&spawnpoints=%%spawnpoints_display%%

They dont equal, so it never actually pulls the scan location. Im not sure why the server_type value is being modified...

Im running on PokemonGoMap server 3.1

EDIT: Solved this by deleting and reinstalling the app. I think my NSUserDefaults was working off an old version's value. This kind of issue could be solved by resetting/updating the appropriate values if the application is updated. Or use an enum to determine which server type is being used.