search

istornz / iPokeGo

A native iOS client to map the Pokemon around you!
https://github.com/RocketMap/RocketMap
MIT License
642 stars 168 forks source link

Crash with pokestops on #245

Closed thisismohitgupta closed 8 years ago

thisismohitgupta commented 8 years ago

There are huge number of pokestops in the json response so we need to check if a pokestop or a gym is in for eg 10km....5km range of the scan location and add them to the map. If not done the app simply crashes due to memory issue

dmunozfer commented 8 years ago

Pokemon map raw_data endpoint has 4 parameters to set coordinates.. we could use this to reduce json results (and size):

raw_data implementation

thisismohitgupta commented 8 years ago

Already Implemented this @dmunozfer Thanks I will submit a pull request but there's a bug When the user long clicks the second time on the map The pokestops near old search location are removed and new ones are added near the new location. But the array which operates this is mutated simultaneously by two functions so I get an error - array mutated when iterating, any fixes for this ?

thisismohitgupta commented 8 years ago

Ok Fixed! The problem was lack of sleep apparently 😿