follow location bug - Githubissues

istornz / iPokeGo

A native iOS client to map the Pokemon around you!

https://github.com/RocketMap/RocketMap

MIT License

642 stars 168 forks source link

follow location bug #252

Closed Jones1337 closed 8 years ago

Jones1337 commented 8 years ago

i think the app can't handle the follow position feature while running in background.

dmunozfer commented 8 years ago

We have 2 CLLocationManager, one in AppDelegate and the other in MapViewController.

Perhaps we should make the delegate of CLLocationManager in AppDelegate was MapViewController? Is it possible?

Jones1337 commented 8 years ago

I think it's not good to deactivate follow position when you zoom out to see more pokemon. Everytime I zoom out, I have to press and hold the position button again to reactivate scan follow position feature

dmunozfer commented 8 years ago

Follow location only should be disabled when user scrolls map with 1 finger.. zoom should not disable it. Are you using the latest version?

Jones1337 commented 8 years ago

yes, i am. and i just found out, when you scroll the map it's deactivated again :/

dmunozfer commented 8 years ago

Using ios 9.3 and iPhone 6 do not have that problem. What versions do you use?

SnakeIz commented 8 years ago

Why am I not seeing a follow location option? I have it connecting to pokemongo-map?

Jones1337 commented 8 years ago

@dmunozfer exactly the same, iOS 9.3 + iPhone 6 ...

dmunozfer commented 8 years ago

@SnakeIz to enable follow location do long press on gps button @Jones1337 I can not have the same behavior... can you try to pan/scroll with 2 fingers? what it does?

Jones1337 commented 8 years ago

With two Fingers it doesnt happen but i think it shouldnt fail with one finger?!

dmunozfer commented 8 years ago

This feature was implemented in this PR #214 @istornz @markvl91 Maybe we should enable/disable this from settings?

istornz commented 8 years ago

@dmunozfer Yes, I think it's more intuitive :)