search

istornz / iPokeGo

A native iOS client to map the Pokemon around you!
https://github.com/RocketMap/RocketMap
MIT License
643 stars 173 forks source link

Expired Pokemon still getting stuck #285

Closed TheNewDarkOne closed 7 years ago

TheNewDarkOne commented 7 years ago

Despite the commit few days ago I'm still getting this issue a LOT. Expired pokemon keep flickering on the map and spamming notifications. As an example, a Vulpix expired and disappeared but every 1 second it'd reappear send a notification get removed then reappear send notification get removed etc. For some reason it keeps getting re-added to map even though it's expired and only way to fix it is to restart the app when this happens. It happens at least once or twice an hour.

SnakeIz commented 7 years ago

Same issue, driving me crazy. Wish I knew or had someone that could compile the most recent code for me

TheNewDarkOne commented 7 years ago

Snake, it's not fixed in latest code, that's what my ticket is about. I have absolute latest code compiled fresh and it still happens.

istornz commented 7 years ago

@TheNewDarkOne @SnakeIz What is the type of your server ?

TheNewDarkOne commented 7 years ago

https://github.com/PokemonGoMap/PokemonGo-Map

Latest dev.

Bizadon commented 7 years ago

@istornz have the same issue. I admited that issue occures when you switch on showing only lured pokestop, whats wrong with it?

istornz commented 7 years ago

@Bizadon @TheNewDarkOne I think the problem is fixed with the latest commit, can you confirm plz ?

Bizadon commented 7 years ago

@istornz Updated today, still have pokemons, that get stuck. Its looks like: it dissapears, then appears 2-3 times again for just a moment (you can look on it only if you watch over the pokemon) without timer ovet it, just having "-" instead of timer. Not so much problem if notifications for that pokemon are off, but if notifications are on it just like you tap the notification, map follows the location of appearing pokemon, but it is already dissapeared and nothing there on map.

leolobato commented 7 years ago

Found the issue. This will constantly happen when the server clock is different than the iOS device.

Bizadon commented 7 years ago

@leolobato when the clock is different then the timer is more or less, just that. I tried it with server clock -1hour, pokemons just have much more time to expire. In this situation they are getting stuck and have "-" instead of timer.

leolobato commented 7 years ago

In my case the server was off by -6 hours (I think). The pokemons would be added to the map by - processPokemonFromJSON:usingContext: and then removed by -cleanData.

istornz commented 7 years ago

@leolobato @Bizadon Ok nice ! I close the issue now, reopen if needed.