istornz / iPokeGo

A native iOS client to map the Pokemon around you!
https://github.com/RocketMap/RocketMap
MIT License
643 stars 173 forks source link

[feature request] IV and moveset information #322

Closed mlc130104 closed 7 years ago

mlc130104 commented 7 years ago

With a new PR in pokemongo-map (https://github.com/PokemonGoMap/PokemonGo-Map/pull/1272), IV and moveset data are now available in the web interface as well as in /raw_data. I would like to know if iPokeGo could implement this.

istornz commented 7 years ago

When this great feature will be available, I think to remove the "disappear" label on the annotation (you can add the timer it's more useful). What do you think ?

cyan commented 7 years ago

heya, i think, you should add the iv% behind the pokemon name and instead of the disappear label, show the move set (wich sometimes change everything from running like bolt to "keep sleeping its a trash" xD)

toshioson commented 7 years ago

This feature is much wanted, hope it can be implemented soon in iPokeGo!

Besides showing, next step could be to add also as filter for showing the Pokemon if possible?

mbg032373 commented 7 years ago

This PR has been merged. Getting this information into iPokeGo and the ability to sort and get notifications based on IV would be great!

SnakeIz commented 7 years ago

May we please get the display of the IVs and move sets added to ipokego?

SnakeIz commented 7 years ago

Also, include the IV/moves in the push notification.

istornz commented 7 years ago

Now implemented ! Have fun guys ;)

SnakeIz commented 7 years ago

Awesome, thank you!

But can we also have the move set? Important when deciding on chasing a lower CP final evolved pokemon or if time left is short.

mbg032373 commented 7 years ago

Hopefully, you can get around to filtering and notifications based on a specified IV% at some point.

Thanks for the great work!

istornz commented 7 years ago

@SnakeIz Yeah coming soon ! (I have already added these infos in the db 👍 ) @mbg032373 Feature coming in a few hour. I set the IV% point at >= 70% tell me if it's correct :)

istornz commented 7 years ago

@mbg032373 Last commit add Push support for high IV Pokemon only

SnakeIz commented 7 years ago

I would allow the user to set the IV percentages for those features

mbg032373 commented 7 years ago

Yes, user set would be best.

SnakeIz commented 7 years ago

Have an issue with the IV percent that shows. They are incorrect. Earlier tonight I had an eevee that was left 91.1. After that when multiple eevees spawned it still showed 91.1, triggered a notification, but the actual IVs it displayed clearly showed it was not 91.1. What was caught was the IVs that displayed, which again were not 91.1. Bit later there was a legit 71% that spawned and now one that spawned shows 71% but the IVs it shows are 3/1/3.

istornz commented 7 years ago

@mbg032373 Now you can set your custom high IV in settings. @SnakeIz I think it's patched now, can you test again and see if all IVs are correct ?

toshioson commented 7 years ago

@istornz how to compile the latest version including this feature into an iPA? or where can I download one for trial? thanks!

istornz commented 7 years ago

@toshioson Enjoy ! https://github.com/istornz/iPokeGo/releases/tag/V2.4

mlc130104 commented 7 years ago

The new threshold (80%) is nice enough, tho IIRC the wonder appraisal happens when total IV > 82%.

toshioson commented 7 years ago

@istornz I sideloaded the IPA file onto my iPhone, trusted in device management but it won't start. Removed and sideload again does not help. Tried on another iPhone and got the same problem. Is it my problem?

congbosun commented 7 years ago

@istornz @toshioson I got the sam problem!

kallik commented 7 years ago

Hi, first off, love the app!

I noticed when a pokemon appears with the "hot_pokemon" image overlay that pokemon appears "hot" next time it spawns whatever iv that pokemon might have. Maybe because of the reuse logic in PokemonAnnotationView init function. I patched it temporarily by colring the time-left tag red for hot pokemons.

istornz commented 7 years ago

PokeGO V2.4 is now available on the AppStore :+1: https://itunes.apple.com/us/app/ipokego-for-pokemon-go/id1138277066?l=fr&ls=1&mt=8