istrategylabs / franklin

MIT License
1 stars 1 forks source link

Builder to clone private repos #87

Closed oudeismetis closed 8 years ago

oudeismetis commented 8 years ago

This will require builder using deploy keys when cloning the repo.

Steps:

https://developer.github.com/guides/managing-deploy-keys/ https://github.com/blog/2024-read-only-deploy-keys

This appears to be the best/only approach.

oudeismetis commented 8 years ago

https://gist.github.com/lkdocs/6519378 Spoiler: Apparently pycrypto is broken in python 3.5 v2.7 will apparently fix this, but it's not live yet on pypi.

oudeismetis commented 8 years ago

I know this because I tried to YOLO the API side of this issue.

oudeismetis commented 8 years ago

Just circling back as this story is likely being worked soon. Looks like pycrypto hasn't had a version bump since 2014 and only has a couple of active contributors. We should probably investigate another way to generate the keys we need in python 3.5 They do have an experimental version of the library that may have the fix we need in it. (or we fork it and fix it ourselves, contributing back)

oudeismetis commented 8 years ago

Will have a PR open that implements the API side of this shortly.