search

istreamlabs / pebble

Pebble Design System
https://pebble.istreamplanet.net
Apache License 2.0
14 stars 4 forks source link

New icons for Icon component #346

Closed jphillips-isp closed 3 years ago

jphillips-isp commented 3 years ago

Proposed Changes:

Adding new svg icons

osbornm commented 3 years ago

Should this be merging into main? Why into styling?

osbornm commented 3 years ago

The pipline icon should not be in pebble. Pebble is meant to be "business agnostic" and this is a very specific business graphic. Additionally, it's not really an icon and does not fit the standard sizes.

esjaastad-isp commented 3 years ago

Should this be merging into main? Why into styling?

@osbornm Looks like minor releases are going through the styling branch https://github.com/iStreamPlanet/orbis-web-portal/pull/1381#discussion_r528959568

osbornm commented 3 years ago

Should this be merging into main? Why into styling?

@osbornm Looks like minor releases are going through the styling branch iStreamPlanet/orbis-web-portal#1381 (comment)

This need to be fixed. We should only be doing releases out of main. This could lead to numerous issues.