istreamlabs / pebble

Pebble Design System
https://pebble.istreamplanet.net
Apache License 2.0
14 stars 5 forks source link

feat: add fieldSelect with dynamic options #411

Closed erwinmurni closed 2 years ago

erwinmurni commented 2 years ago

Why is this change being made: To enable dynamic options returned from api

What is being change:

Does this change break anything: No

https://user-images.githubusercontent.com/41709608/136292803-4290b753-4336-4d87-97af-767126dc0983.mov

github-actions[bot] commented 2 years ago

:eyes: Test Deployment :eyes:

esjaastad-isp commented 2 years ago

Since you have this open, I noticed that ariaLabel and ariaLabelledby are not what react-select is expecting and they seem to be passed in as is. https://react-select.com/props#select-props