Make scuitls Logger callbacks Python 2 and Python 3 compatible

istresearch / scrapy-cluster

This Scrapy project uses Redis and Kafka to create a distributed on demand scraping cluster.

http://scrapy-cluster.readthedocs.io/

MIT License

1.18k stars 324 forks source link

Make scuitls Logger callbacks Python 2 and Python 3 compatible #118

Closed joequery closed 7 years ago

joequery commented 7 years ago

I eliminated the Mixin style inheritance scheme between Logger and LogCallbackMixin and went with a more standard "has-a" relationship.

I've verified the changes pass all tests in the utils directory for Python 2.7.13 and 3.5.3.

While this does not address the RedisPriorityQueue issue, I don't think it necessarily needs to be addressed yet to get scutils itself usable across python 2 and python 3.

madisonb commented 7 years ago

@joequery do you have an idea why the unit tests failed for half of the project?

madisonb commented 7 years ago

After looking at this PR, I am going to close it and reproduce the changes made here in a cleaner manner, and resubmit to the dev branch. We also have some ideas to better control how dev scutils can be installed via travis for PR's.