search

istresearch / scrapy-cluster

This Scrapy project uses Redis and Kafka to create a distributed on demand scraping cluster.
http://scrapy-cluster.readthedocs.io/
MIT License
1.18k stars 323 forks source link

Typo on document of Kafka-monitor API section #183

Closed chihkaiyu closed 6 years ago

chihkaiyu commented 6 years ago

Hi all, I'd found a typo on this page: demo.crawled_firehouse. It should be demo.crawled_firehose and I think it's just a typo. I was stuck for a while and kept diving into the code to see if I did something wrong lol Maybe we should add a warning (or an exception) here if someone tries to dump the result from a non-exist Kafka topic. Not just create a topic and keep dumping the result from it but this is not the issue we want to discuss here. Here is the related PR: https://github.com/istresearch/scrapy-cluster/pull/184

madisonb commented 6 years ago

Good catch, I am impressed that typo lasted as long as it did. Fixing right now... Ah I see you already made a PR -> I will resolve it here soon.

madisonb commented 6 years ago

PR Merged, closing.