PEP8 compliance and some other cleanups

[coveralls]

Coverage decreased (-0.08%) to 65.212% when pulling 5cf6aaf7618641e3be39d3d188f32364f68066df on tarhan:dev into ac4ba8a47d745a16c8399b443b9f429f4c845403 on istresearch:dev.

[madisonb]

What tool did you use to format everything? I always use Sublime but obviously it lets you get away with a lot more stuff.

Interesting that the build failed, I presume I need to add a flag here to check if it also is a PR so it does not try to push to docker hub with invalid creds.

Otherwise my last note is Why did coverage go down? I understand there are typos and some PEP8 formatting, but I would presume coverage would remain the same. Thoughts? I will have to look at the coverage reports for these files:

• kafka-monitor/kafka_monitor.py
• crawler/crawling/spiders/wandering_spider.py
• redis-monitor/plugins/base_monitor.py
• crawler/crawling/spiders/link_spider.py

as those appear to be the ones who went down.

[tarhan]

I'm using PyCharm mainly because its embedded debugger and intellisense features. Former allows me to debug Python apps like any compiled apps even on remote hosts (other hosts or inside Docker). So it is very good for if I need to do step by step debugging for app contained inside Docker container.
Latter can be archived for Sublime with Anaconda plugin. But at time I used it I failed to do its correct configuration for its linter and intellisense. It very often hangs whole Sublime. I'm not sure how its working now.
PyCharm's inspections feature allows me to not only to find PEP8 and other warnings but also do automatic corrections where it is possible.

Yeah, because you pass DOCKER_USERNAME and DOCKER_PASSWORD only for your builds.

As for coverage I'm not sure. I will investigate it

[madisonb]

Any update as to why coverage dropped?

[madisonb]

Closing for now.