isudatateam / datateam

ISU Data Team Effort
MIT License
5 stars 3 forks source link

Edits needed to DWM data #273

Closed loriabendroth closed 3 years ago

loriabendroth commented 3 years ago

@giorgichi , edits are needed to the DWM tab. I have completed a few of them already. Please complete others.

giorgichi commented 3 years ago

@loriabendroth, all v-notchs are replaced with V-notch.

giorgichi commented 3 years ago

I think I found all personal references and removed them. Few comments were modified to passive voice.

giorgichi commented 3 years ago

In comments, it often says "controlled drainage" or "free drainage". This needs to be a complete sentence. Does this mean it was put into controlled drainage mode from free drainage mode? And vice versa for free drainage?

I assume so too. I will change "controlled drainage" and "free drainage" to "Controlled drainage treatment plot was put in managed drainage mode." and "Controlled drainage treatment plot was put in free drainage mode." respectively. This is a wording that is used by the same PI (Kelly Nelson) for other entries.

giorgichi commented 3 years ago

@loriabendroth,

I also changed "Controlled Drainage mode" and "Drainage mode" to "Controlled drainage treatment plot was put in managed drainage mode." and "Controlled drainage treatment plot was put in free drainage mode." respectively. This is a wording that is used by Kelly Nelson for other entries.

giorgichi commented 3 years ago

In box_structure, should zone be capitalized at DEFI_R?

There is no need to capitalize zone. I will keep it as it is.

loriabendroth commented 3 years ago

@giorgichi , I like the changes you made for drainage mode explanation in comments.

giorgichi commented 3 years ago

HEIGHT is capitalized often in comments. Is this appropriate?

@loriabendroth, this is an important detail. Usually, outlet depth is reported as DEPTH from the soil surface. However, for WIRSIS sites this is reported as HEIGHT from the bottom of the control structure. Even those both are measuring the same thing, the reference point (and direction of measurement) are different.

One way to eliminate this is to create a new variable called outletheight, which will contain that data.

One more thing, FULTON has only one entry. Knowing board hight at one specific time doe not really have much value, so I am going to mark it remove in the action column.

Your thought about the last two points.

giorgichi commented 3 years ago

Rewriting some comments:

giorgichi commented 3 years ago

HEIGHT is capitalized often in comments. Is this

A new column outletheight added to accommodate corresponding data. Some comments contained information about outlet heights (most of OH sites), which were also moved there (and removed from the comments as accordingly).

giorgichi commented 3 years ago

Ensure standard language used across sites. For example, what are "drop logs" compared to "boards"?

Left intact as it often corresponds to the language used by PIs in their peer-reviewed publications.

giorgichi commented 3 years ago

Some comments at CLAY_R were redundant and replaced with "n/a".

giorgichi commented 3 years ago

Some comments at DEFI_M were redundant and replaced with "n/a".

loriabendroth commented 3 years ago

HEIGHT is capitalized often in comments. Is this

A new column outletheight added to accommodate corresponding data. Some comments contained information about outlet heights (most of OH sites), which were also moved there (and removed from the comments as accordingly).

Good. I was going to respond to earlier comment to add column since it is a different variable. Update data dictionary accordingly.

loriabendroth commented 3 years ago

Ensure standard language used across sites. For example, what are "drop logs" compared to "boards"?

Left intact as it often corresponds to the language used by PIs in their peer-reviewed publications.

For clarity of the user, when the text is referring to the same thing ("board"), I think best to standardize. To retain specificity used in the journal article, can you put in quotes following text such as "drop logs (i.e. "boards")".

loriabendroth commented 3 years ago

Regarding: One more thing, FULTON has only one entry. Knowing board hight at one specific time doe not really have much value, so I am going to mark it remove in the action column.

Agree. Fine to remove. Put a note in Notes that no board heights were reported for the site years.

loriabendroth commented 3 years ago

I think I found all personal references and removed them. Few comments were modified to passive voice.

One remaining reference: DEFI_R 2003 has "I stopped..."

loriabendroth commented 3 years ago

@giorgichi couple remaining comments that could possibly be generalized more for external user or removed. Such as reference to DARA at DEFI_R sites. I haven't seen DARA abbreviation before so if retain, make sure to define. "Plates removed..." terminology at SERF_IA seems like it should be standardized how you changed others to be "controlled drainage treatments plots had..." Also, in 2017 and 2018, comments at SERF_IA are including plot numbers which are unnecessary. Same with TIDE in 2007. And UBWC - remove reference to multiple plots when row entries are for 1 specific plot.

giorgichi commented 3 years ago

Remove plot names in comments at SERF_IA.

giorgichi commented 3 years ago

Removed plot names in comments at TIDE.

giorgichi commented 3 years ago

Comments with plot names rewritten at UBWC.

giorgichi commented 3 years ago

DARA remove from the comments at DEFI_R.

giorgichi commented 3 years ago

Comments updated at SERF_IA.

"Plates removed..." terminology at SERF_IA seems like it should be standardized how you changed others to be "controlled drainage treatments plots had..."

giorgichi commented 3 years ago

The name was standardized as applicable. Flashboard, drop log, plate, outlet board, riser boards, and gate were replaced with the board.