isudatateam / datateam

ISU Data Team Effort
MIT License
5 stars 3 forks source link

Edits during review period (9/19 - 10/20) #83

Closed loriabendroth closed 6 years ago

loriabendroth commented 6 years ago

MISC

Map

Treatments Tab

Data Tabs

Weather Data

Export Items

Misc

akrherz commented 6 years ago

Regarding

Check the GHG data – I have all sites selected yet these 4 are not options to select:

For GHG09, GHG10, GHG15 and GHG16, we don't have any data. Shall I just remove those options from the page?

akrherz commented 6 years ago

Regarding

in email text, add a line between last two paragraphs

what do you mean by 'a line' ? A vertical spacing? The email is non-HTML, so we can't do HTML elements at this time

akrherz commented 6 years ago

Regarding

the data dictionary in export does not match the report in SS (Sustainable Corn data Dictionary (export)) in regards to sorting. The SS report is how it should look in the export.

This is a tough one, but I hacked something in to make this happen soon.

loriabendroth commented 6 years ago

@akrherz thanks for getting these addressed, looks good!. Couple minor things:

giorgichi commented 6 years ago

@loriabendroth updated GHG data was sent to Daryl 3 days ago (9/18/2017). Not sure what do you ask me to send.

akrherz commented 6 years ago

Regarding

Note that the citation starts with a new line after authors and year. So that the title and source are on a new line; bring up to follow directly after year.

I am fairly certain what you are seeing is email client dependent, it appears fine for me.

loriabendroth commented 6 years ago

@akrherz few new edits up at top regarding exported file.

akrherz commented 6 years ago

@loriabendroth regarding

in earlier request, weather file exports were renamed to site name. Can CSCAP uniqueid be added also; something like BRADFORD.A_MO1791.

Not at this time, same issue as the request to add this ID as a column to the sheet.

loriabendroth commented 6 years ago

@akrherz ok, i was wondering. not a big deal.

loriabendroth commented 6 years ago

I brought this job back to life as misc edits will keep coming. I put a few new ones at top that I noticed when working with data.

giorgichi commented 6 years ago

@loriabendroth, sure.

loriabendroth commented 6 years ago

@akrherz is it possible to remove data for certain sites and years that have no soil data at all in the export? I have downloaded all soil data and there are many rows with NA all the way across. For example, ORR, plot 3092, 40 to 60 depth, subsample 2, year 2012. I think its still good to keep original Google entry sheets as is, but just remove from export.

loriabendroth commented 6 years ago

@akrherz sorry for the great pain caused by my previous request :) A few new misc items up top. I may add some more later on today also.

giorgichi commented 6 years ago

Plots with ROT18, ROT19, and ROT20 were not part of the original research. These plots were added later as part of IPMUSB research. That is why these rotations were not in the DD originally. Now all three rotations are added to the DD.

giorgichi commented 6 years ago

@loriabendroth ROT62 != ROT7

loriabendroth commented 6 years ago

@giorgichi ok, yes, you are correct. I am just perpetually confusing myself. @akrherz for the export, can we just change the rotation codes on a few? For example, ROT62 would become ROT7v to stand as a variant of ROT7 to signify that it is similar but not identical. Possible? If so, this would apply to just a few cases.

giorgichi commented 6 years ago

@akrherz soil series name/description is missing for some plots in BRADFORD.B2 when I export the data. Although all plots have it in Google Sheet. Could you update plot identifier table, hope this will solve the issue.

akrherz commented 6 years ago

@akrherz soil series name/description is missing for some plots in BRADFORD.B2

Yeah, the script that syncs plotids is not scheduled to run every day, so I had to manually run it and update the database schema to include the new "timing" column that appeared in the KELLOGG sheet.

The database contains one plotid now without soiltextureseries1 defined, want to fix?

select plotid, uniqueid from plotids where soiltextureseries1 is null or soiltextureseries1 = '';
 plotid |  uniqueid  
--------+------------
 118T   | NAEW.WS118
(1 row)
akrherz commented 6 years ago

@loriabendroth regarding

For example, ROT62 would become ROT7v to stand as a variant of ROT7 to signify that it is similar but not identical. Possible? If so, this would apply to just a few cases.

I am not following what you are asking for. You want me to make this substitution within the database or when the export spreadsheet is materialized?

giorgichi commented 6 years ago

@akrherz thanks for pointing out at missing soil series at NAEW.WS118. It is fixed now.

loriabendroth commented 6 years ago

@akrherz the timing column will eventually come out of KELLOGG (and MASON). It is just there as a placeholder now until we get clarification from site personnel on the treatment configuration.

loriabendroth commented 6 years ago

@akrherz for the rotation codes, I am wondering if possible for when export spreadsheet is materialized. I dont want you reworking all database structure and past programming. If possible, then @giorgichi or I can tell you which to change.

giorgichi commented 6 years ago

@loriabendroth - I went through the site notes again to remove (make invisible) unimportant entries. I managed to get rid of 60 of them. Now we are down to 162 entries. I recommend you to read those ones and make a final decision which notes are suitable.

akrherz commented 6 years ago

@loriabendroth regarding

Is there a limit to how many names the weather file will export as a stacked file name? 4 worked. 8 did not.

Large filenames can cause grief, so there are practical limits at play

loriabendroth commented 6 years ago

@akrherz regarding weather filenames, can you add to the statement at end of weather page whatever the limit is? i.e. If sites downloaded are between 1 and 4: The downloaded data file will have the name of the networked Weather Station.... If sites downloaded are greater than 4: The downloaded data file will be named "changeme" and the user will need to reference the drop-down above for which sites were selected.

loriabendroth commented 6 years ago

@giorgichi I like using "Universal" in place of "Global" to describe the variables that go across.

giorgichi commented 6 years ago

@loriabendroth Global is substituted with Universal in DD

akrherz commented 6 years ago

regarding

Is there a limit to how many names the weather file will export as a stacked file name? 4 worked. 8 did not. The limit is 10 and should be denoted on the interface now

giorgichi commented 6 years ago

@akrherz - I updated Landscape column for all CSCAP sites in Plot Identifiers. I entered "N/A" for sites that do not have landscape positioning as treatment. Could you sync again Plot Identifiers with the db.

akrherz commented 6 years ago

@giorgichi the plot ids have been synced

loriabendroth commented 6 years ago

@giorgichi regarding this: change title for data on USDA NAL page to “Sustainable Corn CAP Research Data (USDA-NIFA Award No. 2011-68002-30190).” I was referring to the title in the data citation. So it should be "... Villamil. 2017. Sustainable Corn CAP Research Data (USDA-NIFA Award No. 2011-68002-30190). National Agricultural..." Notice that this title in the citation is the title in the NAL portal. The NAL creates the citation we are using - you can scroll to bottom of NAL page to check that everything matches with what we have on /dl.

loriabendroth commented 6 years ago

@giorgichi need to correct header language for Tile Flow, Water Table, and Water Quality. Notice that it refers to two USDA-NIFA funded projects, it should be: "are associated with the USDA-NIFA funded project:"

loriabendroth commented 6 years ago

@akrherz notice a couple jobs up at top for you!

giorgichi commented 6 years ago

@loriabendroth - title you want to use does not match with the citation in NAL portal. Could you recheck the wording for the title before substituting it with another one?

giorgichi commented 6 years ago

Project title was changed in NAL to match with Lori's new version.

akrherz commented 6 years ago

@loriabendroth regarding

check admin page. Note that Peter Scharf downloaded file on 10-21 and 10-22 but he is not shown as logging in on either day. Are admin controls working correctly regarding logins?

The access controls were removed from the sustainablecorn portion of the website on 20 Oct, I verified that the download was properly logged for those two dates.

giorgichi commented 6 years ago

@loriabendroth - I updated variable codes in DD (AGR1 => AGR01, etc.)

loriabendroth commented 6 years ago

@giorgichi technical report tab looks terrific! can you just make so the hyperlinks open in a new browser tab?

loriabendroth commented 6 years ago

@akrherz @giorgichi just noticed error on Refereed Journals tab. Scroll to the bottom - you'll see technical report text that should be deleted.

giorgichi commented 6 years ago

@akrherz I know what is causing this problem

I selected all sites and all treatments, but two agro variables grey out - corn cob total N at R6 and mid-season canopy N sensing. Check on this; the data exist. Aggregate stability under Soil is also greyed out when all are selected.

But I am not sure how to fix. Can you help me now?

akrherz commented 6 years ago

added landscape values of 'N/A' to always be included in filter with 291691d3d2583a6550e2cab7355271410e132863

giorgichi commented 6 years ago

@loriabendroth - export tool currently is not capable to do this:

check years populated in tool for WOOSTER.COV for soil organic carbon. 2011 was greyed out but 2012 should also be because we are not including bc of quality concerns. 2012 is not in the exported file

You can confirm it with @akrherz

akrherz commented 6 years ago

@loriabendroth regarding

check years populated in tool for WOOSTER.COV for soil organic carbon. 2011 was greyed out but 2012 should also be because we are not including bc of quality concerns. 2012 is not in the exported file.

Currently, the filter logic for years includes a general check against GHG data. I have made it explicit now.