search

isuru89 / moodle-local_reminders

A Moodle local plugin for automating email reminders for calendar events
https://moodle.org/plugins/local_reminders
28 stars 31 forks source link

Email reminders are sent for hidden assignments #175

Closed hannibal001001 closed 10 months ago

hannibal001001 commented 10 months ago

Hello Isuru,

The email reminders are sent to the teachers and students even if the assignments still hidden. Will be great if this bug will be fixed:-)

Best regards,

Valentin Green

Environment (required):

isuru89 commented 10 months ago

@hannibal001001 Do you mean the hidden as the 'Availability' flag in common module settings? If not, could you please add the reproducible steps, so that I can respond to the issue faster.

image

hannibal001001 commented 10 months ago

Hello Isuru, Thank you for your quick answer. By hidden I mean a "hidden assignment for the students". For example, a course has been built in Aug 2023. The course has a couple of assignments( with the correspondent "allow submission from", "due date", "cut-off date",... ). The first assignment has Oct 22 for "allow submission from", and Nov 03 for "due date". Until here nothing spectacular. At some moment we began to receive OVERDUE emails( both teachers and students ). And this seem to be the bug! Let me elaborate: For all kind of reasons, the course still "on hold", with the assignments set to "Hidden for students"! Basically the students cannot touch the assignments, so it's not a fair to get "OVERDUE emails". Best regards, Valentin Green

isuru89 commented 10 months ago

I tried to recreate the issue in below scenario, but all was unsuccessful. Overdue reminders were not sent when the course or the assignment is hidden.

  1. Course is hidden for students - Assignment from this course were visible on the Moodle calendar but No overdue reminders were sent. image

  2. Assignment made hidden on course page (as in my previous thread) - Assignment is hidden in Moodle calendar and no overdue emails were sent.

@hannibal001001 I wonder, how did you made the course "on hold"? Doesn't it belong to either one of those above steps?

If not, could you please kindly provide an actual reproducible steps on how to create such a course and assignment and then task logs.

hannibal001001 commented 10 months ago

@isuru89, Please accept our apologizes. The problem was on our side( a deeply wrong usage of the hide-view property...). About your question, well, it's hard to reproduce the events. A couple of Moodle 3.10 sites migrated to Moodle 4.1. And some courses get transferred too. Here, on Moodle 4, a couple of courses were handled in a wrong manner... Again, we're sorry for this "false alarm"