search

it-at-m / digiwf-core

central workflow automation and integration platform based on the free process framework Camunda.
MIT License
19 stars 7 forks source link

Property mismatch in class CronJobConfiguration.java of digiwf-s3-integration-starter #1706

Closed boal closed 2 months ago

boal commented 4 months ago

Describe the bug

The digiwf-s3-integration-starter has an property mismatch in class CronJobConfiguration.java. To enable the cronjobs the propeties under de.muenchen.oss.digiwf.s3.cronjob.cleanup are expected. The properties under `io.muenchendigital.digiwf.s3.cronjob.cleanup are only used to define the cronjob intervall.

https://github.com/it-at-m/digiwf-core/blob/fccc8eeb3b705064741f772cd3092b6393d33a11/digiwf-integrations/digiwf-s3-integration/digiwf-s3-integration-starter/src/main/java/de/muenchen/oss/digiwf/s3/integration/configuration/CronJobConfiguration.java#L15

image

To Reproduce Steps to reproduce the behavior:

  1. Define properties of io.muenchendigital.digiwf.s3.cronjob.cleanup.expired-files and io.muenchendigital.digiwf.s3.cronjob.cleanup.unused-files
  2. Do not define properties of de.muenchen.oss.digiwf.s3.cronjob.cleanup.expired-files and de.muenchen.oss.digiwf.s3.cronjob.cleanup.unused-files
  3. The cronjobs are not configurated because the ConditionalOnProperty-Annotation is not triggered.

Expected behavior

A definition of the properties under `io.muenchendigital.digiwf.s3.cronjob.cleanup should be sufficient .

Screenshots n/a

github-actions[bot] commented 4 months ago

👋 Thanks for reporting! The maintainers have been notified and will get back to you.

darenegade commented 4 months ago

@markostreich @simonhir

Hier sollten alle Properties umgestellt werden:

https://github.com/it-at-m/digiwf-core/blob/dev/docs/src/integrations/digiwf-s3-integration.md#konfiguration

darenegade commented 4 months ago

Es gibt noch einige Stellen, wo noch die alte Domain verwendet wird:

https://github.com/search?q=repo%3Ait-at-m%2Fdigiwf-core+io.muenchendigital&type=code&p=1

darenegade commented 4 months ago

@boal Wir werden das bei uns einplanen und umsetzen

boal commented 4 months ago

Beim client der s3 integration gibt es einen mismatch bei der Propertybenennung.

image

versus

image

markostreich commented 3 months ago

Die S3 Properties werden umbenannt, sodass sie ohne package-Namen mit digiwf beginnen.

lehju commented 3 months ago

Ops MR: https://git.muenchen.de/digitalisierung/digiwf/digiwf-ops/-/merge_requests/470