search

it-at-m / digiwf-core

central workflow automation and integration platform based on the free process framework Camunda.
MIT License
19 stars 7 forks source link

Feauter/archunit hexagonal #1811

Closed simonhir closed 4 months ago

simonhir commented 4 months ago

Description

Refactor ArchUnit hexagonal architecture test.

Reference

Issues: #1465

Check-List

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 73.25581% with 23 lines in your changes missing coverage. Please review.

Project coverage is 46.29%. Comparing base (38396f0) to head (f41893e). Report is 4 commits behind head on dev.

Files Patch % Lines
...gration/adapter/in/streaming/StreamingAdapter.java 0.00% 12 Missing :warning:
...r/adapter/out/camunda/rest/ToEngineDataMapper.java 78.57% 2 Missing and 1 partial :warning:
...ion/application/usecase/PingAlwServiceUseCase.java 40.00% 2 Missing and 1 partial :warning:
...gration/adapter/in/streaming/StreamingAdapter.java 93.54% 1 Missing and 1 partial :warning:
...nnector/adapter/in/camunda/rest/CamundaClient.java 50.00% 1 Missing :warning:
.../adapter/in/camunda/rest/FromEngineDataMapper.java 0.00% 1 Missing :warning:
.../rest/DigiWFCamundaConnectorAutoConfiguration.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1811 +/- ## ============================================ - Coverage 46.34% 46.29% -0.05% + Complexity 1028 1024 -4 ============================================ Files 506 503 -3 Lines 7764 7752 -12 Branches 466 466 ============================================ - Hits 3598 3589 -9 + Misses 4012 4009 -3 Partials 154 154 ``` | [Flag](https://app.codecov.io/gh/it-at-m/digiwf-core/pull/1811/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=it-at-m) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/it-at-m/digiwf-core/pull/1811/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=it-at-m) | `46.29% <73.25%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=it-at-m#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

simonhir commented 4 months ago

Es gibt unterschiedliche Versionen von .domain.model.: .model., .domain., was man noch vereinheitlichen könnte.

Habs jetzt soweit vereinheitlicht, dass es nur .domain.* gibt, aber nicht ob es darin, dann nochmal einen model-Ordner gibt. Macht vll beides Sinn, je nachdem wie umfangreich die Integration ist.