it-at-m / helm-charts

it@M Helm Charts
https://artifacthub.io/packages/search?repo=it-at-m
MIT License
6 stars 3 forks source link

Add Renovate for Helm Charts #44

Open hupling opened 1 month ago

hupling commented 1 month ago

Hi @eidottermihi , baust du den Renovate Bot noch in dein Helm ein? Also wenn wir das Refarch Apigateway dann als Helm Dependency einbinden ist das noch sinnvoll. Der @devtobi meinte dafür muss irgendwie ein zusätzliches Plugin verwendet werden . https://docs.renovatebot.com/presets-customManagers/

eidottermihi commented 1 month ago

I'm open for contributions, as long as Renovate PRs are then able to automatically bump the chart version (that's currently the reason why helm is disabled in the renovate config).

devtobi commented 1 month ago

I'm open for contributions, as long as Renovate PRs are then able to automatically bump the chart version (that's currently the reason why helm is disabled in the renovate config).

That's what I saw as well when checking the behaviour of the preset. Thats why I'd suggest to either:

  1. leave Renovate out and do Helm chart bumps manually,
  2. add custom GitHub actions logic that runs after a PR by Renovate was created and automatically bumps helm chart version or
  3. Let Renovate create the PR for the bump of the image version and add another manual commit to bump the helm chart version

@eidottermihi @hupling Which would you prefer? Which do you think is less error-prone?

eidottermihi commented 1 month ago
  1. leave Renovate out and do Helm chart bumps manually,

thats the current situation ;)

  1. add custom GitHub actions logic that runs after a PR by Renovate was created and automatically bumps helm chart version

No clue if this is doable & not prone for errors

  1. Let Renovate create the PR for the bump of the image version and add another manual commit to bump the helm chart version

I'm open for this one, as long as the "manual commit" is then done by the affected chart maintainers. After adding CODEOWNERS I think this would trigger Review requests from the chart maintainers.

eidottermihi commented 1 month ago

best solution would be that this becomes a feature of Renovate, currently an open feature request: https://github.com/renovatebot/renovate/issues/4728