it-at-m / refarch

Collection of different ready to use reference architecture (RefArch) components developed by it@M.
https://opensource.muenchen.de/in-house-development.html
MIT License
2 stars 2 forks source link

[Bug] The refarch-s3-integration-rest-client-starter always call http://localhost:8086 #146

Closed boal closed 1 month ago

boal commented 1 month ago

Bug description

The Lib refarch-s3-integration-rest-client-starter is sending all requests against the url http://localhost:8086, despite the property refarch.s3.client.document-storage-url ist set to another url.

Reason for this behaviour:

The de.muenchen.refarch.integration.s3.client.ApiClient is created as a Bean in class de.muenchen.refarch.integration.s3.client.configuration.S3IntegrationClientAutoConfiguration without defining the ApiClient.basePath with the value of the property refarch.s3.client.document-storage-url.

image

The default value of the ApiClient.basePath is http://localhost:8086.

image

Expected behaviour

The Lib refarch-s3-integration-rest-client-starter should make all requests against the url defined in refarch.s3.client.document-storage-url.

Steps for reproduction

n/a

Affected version

1.0.0

Affected component

No response

Last working version (optional)

No response

Operating system

No response

Browser

No response

Relevant log output (optional)

No response

Screenshots (optional)

No response

Additional context (optional)

No response

No duplicate

Code of Conduct

welcome[bot] commented 1 month ago

Greetings from Munich! 🥨 Thank you very much for participating in our project by opening this issue! ❤ We will take a look at your issue as soon as possible! 👀

simonhir commented 1 month ago

Should be fixed with release 1.0.1 @boal would be nice if you can give appropriate feedback

boal commented 1 month ago

Thank you! The url is now set correctly.