search

it-dept-cis / Essential-Guide-to-Election-Security

Essential Guide to Election Security
7 stars 0 forks source link

Potential fix for duplicated, html-only theme graphics in PDF #235

Closed jungshadow closed 1 year ago

jungshadow commented 1 year ago

Fixes #233 (and possibly competes with #234).

jungshadow commented 1 year ago

@mike-garcia I realized that I was trying to fix this from the latex-side and not the ReST-side. I used the only directive to target only the html builder for dark images—it worked for my local build. The only (ha!) bummer is that there isn't a good way to handle images with captions, as far as I can tell. But...I might think of something else later. Check out the RTD build—since I can't—and see if it works.

mike-garcia commented 1 year ago

Maturities looks good but mdbr doesn't show the dark image in dark mode. should is be :class: instead of :figclass:?

Also the RTD PR isn't producing a PDF, so I can't check that

jungshadow commented 1 year ago

@mike-garcia Yes, it should have been. Apparently, I forgot to change it back when I switched them to the image directive. How's this?

mike-garcia commented 1 year ago

Still no good. Didn't seem to have any effect

Screenshot 2023-02-03 at 12 33 20
mike-garcia commented 1 year ago

Turns out it was file error. Issue resolved. Waiting on marketing for updated file

fixes #235 fixes #234

closes #233