Closed al-muammar closed 5 years ago
Or we can leave it for now. Because, as I see, we will have to move to DB soon. We will just replace these codes by id and link them.
@rguliev, not entirely sure about your DB idea. What do you mean? :)
I mean that eventually, we will switch to DB anyway. And in DB it will look like two tables pronouns
and verbs
connected by id. So, we will not need "keys" for pronouns to map verb form and a pronoun.
Summary
This PR fixes #23 which is a redundancy that we currently have. All pronouns (except
i
andwe
are coded with first letters of their grammatical features. For example: singular, dual, male = sdm It significantly decreasesverb-forms.json
.Test Plan
Played with our test bot: