search

it-novum / openITCOCKPIT

openITCOCKPIT is an Open Source system monitoring tool built for different monitoring engines like Nagios, Naemon and Prometheus.
https://openitcockpit.io/
GNU General Public License v3.0
263 stars 50 forks source link

Permission Services:externalCommands has no effect #1663

Closed kbilev closed 5 months ago

kbilev commented 5 months ago

Describe the bug We can enable or disable the "Services:externalCommands" permission for a User. This has no effect on the Service Browser. The "Hosts:externalCommands" seems to be used for the service browser. I think it is a copy/paste problem in "/src/Controller/ServicesController.php#L1779" $canSubmitExternalCommands = $this->hasPermission('externalcommands', 'hosts');

To Reproduce Enable and disable the "Services:externalCommands" permission.

Expected behavior Enable or disable the commands on the service browser page.

Versions

kbilev commented 5 months ago

/src/Template/Services/index.php#L1113 seems have the same problem

ibering commented 5 months ago

ITC-3185

ibering commented 5 months ago

Resolved by https://github.com/it-novum/openITCOCKPIT/pull/1667 and will be part of the next release openITCOCKPIT 4.7.2

Many thanks for your support

kbilev commented 5 months ago

probably also "/src/Template/Services/service_list.php" impacted?

ibering commented 5 months ago

@kbilev Of course, you're right. Thanks for that!