Swap Usage calculation on Windows sometimes wrong

exa-mk commented 3 years ago

Agent Mode:

[ ] Pull Model (openITCOCKPIT Server request data from Agent)
[x] Push Model (Agent send data to openITCOCKPIT)

Versions

openITCOKPIT Server Version: 4.2.1
openITCOCKPIT Monitoring Agent Version: 3.0.5

Operating system Windows Server 2019 Datacenter

Do you use an HTTP proxy? no
Are you using Auto-TLS, HTTPS or HTTP? https
Used CPU architecture: amd64

Describe the bug In some circumstances then swap usage is calculated wrong somehow:

    "swap": {
        "total": 1324351488,
        "percent": 149.32699920823435,
        "used": 1977614336,
        "free": 3641704448,
        "sin": 0,
        "sout": 0
    },

There is more free than total and used together... ;) (Usage 150% :D )

To Reproduce Good question... no idea. It's a Windows Terminal Server with some web services. On our other Windows Servers it seems to be fine.

Expected behavior Proper calculation; no misleading alarms.

nook24 commented 3 years ago

This looks like an integer overflow. Windows uses an uint32 in Megabytes to report the current swap usage. We converted Megabytes into bytes but still using a uint32 which results in a maximum swap filesize of 4GB. I think this is the issue.

I will change this to an uint64

nook24 commented 3 years ago

Fixed with 3.0.6: https://github.com/it-novum/openitcockpit-agent-go/releases/tag/3.0.6

it-novum / openitcockpit-agent-go

Swap Usage calculation on Windows sometimes wrong #56