Feature/a11y - Githubissues

it-osu-web / it-osu-pl

IT@OSU Pattern Lab

https://it-osu-web.github.io/it-osu-pl/

3 stars 1 forks source link

Feature/a11y #239

Closed coreymoore closed 3 years ago

coreymoore commented 3 years ago

Resolves

"Skip to main content" link does not jump to main content when left sidebar has content #235
Breadcrumbs have broken ARIA reference #236
Heading hierarchy of pager #238

mel-miller commented 3 years ago

@coreymoore #236, and #238 look good. But #235 contradicts this technique: https://www.w3.org/TR/WCAG20-TECHS/C27.html.

It may make more sense to instead move the <main id="main-content"> so it only wraps the content region instead of all of all four regions that it wraps now. Thoughts?

coreymoore commented 3 years ago

But #235 contradicts this technique: https://www.w3.org/TR/WCAG20-TECHS/C27.html.

It may make more sense to instead move the <main id="main-content"> so it only wraps the content region instead of all of all four regions that it wraps now. Thoughts?

You're right, and I think that makes a lot more sense.

Should the parent classes be renamed? The wrapper for the sidebars and main content have a class named main__inner and that wrapper has a wrapper with a class named layout__wrapper--main.

mel-miller commented 3 years ago

@coreymoore -- I think we can just leave the rest of the naming the same. Probably just move the id to wrap just the content. I have too many moving parts downstream at this point.