Open alinaivanishcheva opened 1 month ago
locally it works fine
A security breach was found in the environment variables configuration while I working on the bug. The general thing is that all environment variables that contain the prefix NEXTPUBLIC would be exposed and put into compiled js values as plain string values. The details can be found in NextJS documentation: https://nextjs.org/docs/pages/building-your-application/configuring/environment-variables#bundling-environment-variables-for-the-browser
To prevent S3 Bucket secrets exposing a PR was opened.
Speaking about the bug, the general approach should be changed because all the secrets would be substituted for server requests only, while none of the secrets would and should be accessible on the UI.
@Wolshebnik as the task owner you should change the overall access of uploaded images via routes (server interactions) only.
cc @alinaivanishcheva
documents in PDF format cannot be opened @Kyslytsia
Environment
Desktop (please complete the following information)
Smartphone (please complete the following information)
Pre-conditions https://chari-erp-dev-5jqgv.ondigitalocean.app/sign-up page is opened. https://www.figma.com/design/al3AkjUmEzr5QEJjKIKkOm/Chari-New?node-id=4760-39039&t=2NBq4VALaGtqMqsp-
Description The uploaded document doesn't open in a new tab when clicking the file icon that doesn't match the requirement for screen resolutions: Desktop 1920, Desktop1440, Tablet 992,Tablet 768, Mobile 375.
Steps to reproduce 1.Open the superadmin dashboard. 2.Select "Requests" (Declined) in the sidebar Desktop 1920. 3.Click on the file icon.
Actual results The uploaded document doesn't open in a new tab when clicking the file icon that doesn't match the requirement for screen resolutions: Desktop 1920, Desktop1440, Tablet 992,Tablet 768, Mobile 375.
Expected results The file icon opens the document in a new tab for screen resolutions: Desktop 1920, Desktop1440, Tablet 992,Tablet 768, Mobile 375.
Screenshots